This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Use Spans to detect "system crate"s, for error deferral (zombie) purposes.#952
Merged
eddyb merged 1 commit intoEmbarkStudios:mainfrom Dec 1, 2022
LykenSol:span-based-system-crates
Merged
Use Spans to detect "system crate"s, for error deferral (zombie) purposes.#952eddyb merged 1 commit intoEmbarkStudios:mainfrom LykenSol:span-based-system-crates
Spans to detect "system crate"s, for error deferral (zombie) purposes.#952eddyb merged 1 commit intoEmbarkStudios:mainfrom
LykenSol:span-based-system-crates
Conversation
Merged
oisyn
approved these changes
Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, the distinction between "user code" and "system code" (e.g.
coreAPIs) was based on the crate "doing the codegen", but#[inline]/genericfns (and even macros) can cause e.g.coreinternals to be codegen'd during the compilation of an user crate.This used to not be a big issue, because "zombies" (i.e. deferred errors) only get silenced when they're in unused code, so they mostly served to hide errors in e.g.
coreinternals that would not be codegen'd at all, had they had#[inline].However, we've accumulated several features which rely on hiding various potentially-zombie things (such as the panic entry-point hijacking, or the "unused
fnparams" weakening), so we need to be using "zombies" (i.e. deferring errors) as much as possible, in order to actually take advantage of that infrastructure.(I could've gone further and removed
is_system_crate, forcingzombie_even_in_user_code's behavior always, but that might lead to confusing outcomes, so I decided against it - for now, anyway)