This repository was archived by the owner on Oct 31, 2025. It is now read-only.
linker/zombies: stop compilation after zombie errors.#950
Merged
eddyb merged 1 commit intoEmbarkStudios:mainfrom Nov 30, 2022
LykenSol:zombie-early-exit
Merged
linker/zombies: stop compilation after zombie errors.#950eddyb merged 1 commit intoEmbarkStudios:mainfrom LykenSol:zombie-early-exit
eddyb merged 1 commit intoEmbarkStudios:mainfrom
LykenSol:zombie-early-exit
Conversation
This was referenced Nov 30, 2022
Merged
oisyn
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a bit silly to get
spirv-valvalidation errors when we already decided compilation won't succeed.(IIRC I did this in a context where this prevents other code from crashing due to invalid SPIR-V)