Skip to content
This repository was archived by the owner on Oct 31, 2025. It is now read-only.

Changed the location of some use statements in tests#931

Merged
eddyb merged 1 commit intomainfrom
lingering-fixes
Oct 19, 2022
Merged

Changed the location of some use statements in tests#931
eddyb merged 1 commit intomainfrom
lingering-fixes

Conversation

@oisyn
Copy link
Copy Markdown
Contributor

@oisyn oisyn commented Oct 19, 2022

See #926 (review)

Basically, not very nice to put the use spirv_std::spirv; on the top line before some test comments.

@oisyn oisyn requested a review from eddyb as a code owner October 19, 2022 10:30
Copy link
Copy Markdown
Contributor

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow I see, most of these needed no imports before!

@eddyb eddyb merged commit 68ddddb into main Oct 19, 2022
@eddyb eddyb deleted the lingering-fixes branch October 19, 2022 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants