Skip to content
This repository was archived by the owner on Oct 31, 2025. It is now read-only.

Prepare invalid-target test for #926#929

Merged
oisyn merged 2 commits intomainfrom
invalid-target-test
Oct 19, 2022
Merged

Prepare invalid-target test for #926#929
oisyn merged 2 commits intomainfrom
invalid-target-test

Conversation

@oisyn
Copy link
Copy Markdown
Contributor

@oisyn oisyn commented Oct 19, 2022

This PR adds the commented out use spirv_std::spirv; to invalid-target.rs in preparation for #926

@oisyn oisyn requested a review from eddyb as a code owner October 19, 2022 08:18
@oisyn oisyn enabled auto-merge (squash) October 19, 2022 08:19
@oisyn oisyn changed the title Invalid target test Prepare invalid-target test for #926 Oct 19, 2022
Comment on lines 30 to 31
// * 6 on `_entry_param`
// * 1 on `_closure`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay good, this accounting (expand to see it above, these are just the last 2 lines of a dozen) is still correct most likely, total error count is still 473.

@oisyn oisyn merged commit 0811739 into main Oct 19, 2022
@oisyn oisyn deleted the invalid-target-test branch October 19, 2022 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants