Conversation
|
Can you try adding tests for these? I thought they couldn't work for now. |
|
They seem to work fine. Any reason why you think they shouldn't? |
|
Is there an example of an existing builtin test somewhere? |
d5aba0a to
f3e14aa
Compare
|
See: #789 (I followed the git blame)
|
f3e14aa to
55f1a88
Compare
|
ok |
|
I think this should be fine to go in if you just back out the workgroup_size change, then. |
|
Let me know if you want me to drop the example. |
eddyb
left a comment
There was a problem hiding this comment.
Looking at the Vulkan spec (since SPIR-V fails to document it), looks like SubgroupLocalInvocationId does indeed go on a variable.
(Whereas for WorkgroupSize it mentions "constants" - though technically ambiguous/a misuse of "variable")
No description provided.