This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Add a OpAtomicIIncrement function to arch#839
Merged
eddyb merged 1 commit intoEmbarkStudios:mainfrom Jan 13, 2022
Merged
Conversation
eddyb
approved these changes
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought I'd just upstream this function from my shader code. While implementing all the atomic instructions with a nice api would of course be nice, this is all you need for doing simple bump allocations into a storage buffer e.g. for frustum or light culling.
I've been using it with the
Devicescope in my code but that's not allowed in the compiletests without a new capability so the test just usesWorkgroupfor now:error: error:0:0 - Use of device scope with VulkanKHR memory model requires the VulkanMemoryModelDeviceScopeKHR capability