This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Add RayQuery::confirm_intersection#822
Merged
khyperia merged 1 commit intoEmbarkStudios:mainfrom Dec 9, 2021
Merged
Conversation
expenses
commented
Dec 9, 2021
| /// [`Self::proceed`] will return `false`.The value returned by any prior | ||
| /// [`Self::proceed`] will return `false`. The value returned by any prior | ||
| /// execution of [`Self::proceed`] with the same ray query object must have | ||
| /// been true. Refer to the client API specification for more details. |
Contributor
Author
There was a problem hiding this comment.
I removed this line just because it wasn't consistent with the rest of the docs and seems to have just been copied from https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_ray_query.asciidoc.
khyperia
approved these changes
Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent like 20 minutes looking for this one before realising that it wasn't implemented 😅
You need this if the ray query flags do not contain
RayFlags::OPAQUE, as otherwise awhile ray.proceed() {}will just skip through all the candidate intersections without confirming any of them. Essentially, you need it for alpha clipping and stuff like that. See here for an example: https://github.com/expenses/transmission-renderer/blob/c5dbd648e513def2719f3971fd5d9c8ce992ba63/shader/src/lib.rs#L736-L766