Skip to content
This repository was archived by the owner on Oct 31, 2025. It is now read-only.

asm: support OpCompositeExtract inference for OpTypeStruct fields.#803

Merged
khyperia merged 1 commit intoEmbarkStudios:mainfrom
LykenSol:infer-access-chain-slice
Nov 22, 2021
Merged

asm: support OpCompositeExtract inference for OpTypeStruct fields.#803
khyperia merged 1 commit intoEmbarkStudios:mainfrom
LykenSol:infer-access-chain-slice

Conversation

@eddyb
Copy link
Copy Markdown
Contributor

@eddyb eddyb commented Nov 20, 2021

The motivation for this was unchecked indexing via asm!, on &[T] (as can be seen in the test) - all the pieces were there, except for the OpCompositeExtract to get the data pointer part of the &[T].

@eddyb eddyb requested a review from khyperia as a code owner November 20, 2021 21:24
Copy link
Copy Markdown
Contributor

@khyperia khyperia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@khyperia khyperia merged commit 553f79e into EmbarkStudios:main Nov 22, 2021
@eddyb eddyb deleted the infer-access-chain-slice branch November 22, 2021 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants