Skip to content
This repository was archived by the owner on Oct 31, 2025. It is now read-only.

Fix the output filename collision warning#669

Merged
khyperia merged 1 commit intoEmbarkStudios:mainfrom
DJMcNab:output-collision
Jun 14, 2021
Merged

Fix the output filename collision warning#669
khyperia merged 1 commit intoEmbarkStudios:mainfrom
DJMcNab:output-collision

Conversation

@DJMcNab
Copy link
Copy Markdown
Contributor

@DJMcNab DJMcNab commented Jun 11, 2021

This works simply by naming the binary crate anything other than the name of the lib, which is example-runner-wgpu.
As far as I know, the warning started in #215

Since there is only one binary crate in the package, the command to run the package (cargo run -p example-runner-wgpu --release) maintains the same behaviour

The cargo issue is rust-lang/cargo#6313

This warning caused problems for me in testing Lokathor/bytemuck#67 since I didn't notice the warning that my patch was not applied (for those interested, bytemuck main is on version 1.6.1-alpha.0, but I was depending on version 1.6.0 from crates.io)

This works simply by naming the binary crate
anything other than the name of the lib, which is example-runner-wgpu
As far as I know, the warning started in
EmbarkStudios#215

Since there is only one binary crate in the package, the command
(`cargo run -p example-runner-wgpu --release`)
maintains the same behaviour

The cargo issue is rust-lang/cargo#6313

This warning caused problems for me in testing
Lokathor/bytemuck#67
since I didn't notice the warning that my patch was not applied
@DJMcNab DJMcNab requested review from VZout, fu5ha and khyperia as code owners June 11, 2021 19:11
@khyperia khyperia merged commit e66e72b into EmbarkStudios:main Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants