This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Added read_subpass for SubpassData images, and necessary attrs for it.#643
Merged
khyperia merged 6 commits intoEmbarkStudios:mainfrom Jun 2, 2021
Merged
Added read_subpass for SubpassData images, and necessary attrs for it.#643khyperia merged 6 commits intoEmbarkStudios:mainfrom
khyperia merged 6 commits intoEmbarkStudios:mainfrom
Conversation
Contributor
|
I think there's a case for keeping "input_" in the name actually, input attachments are such an oddball Vulkan-only thing while attachments are everywhere. |
khyperia
reviewed
Jun 2, 2021
Contributor
khyperia
left a comment
There was a problem hiding this comment.
LGTM, just the one thing!
af35bb6 to
408b5a1
Compare
khyperia
approved these changes
Jun 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decided to call the attribute attachment_index since that is shorter than input_attachment_index, and output attachment indices are just locations, so there's no ambiguity.
Tell me if I should add more tests for error messages!