This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Access the original type's fields through a pointercast, under the Logical addressing model.#469
Merged
khyperia merged 3 commits intoEmbarkStudios:mainfrom Mar 4, 2021
LykenSol:simple-enums
Merged
Access the original type's fields through a pointercast, under the Logical addressing model.#469khyperia merged 3 commits intoEmbarkStudios:mainfrom LykenSol:simple-enums
pointercast, under the Logical addressing model.#469khyperia merged 3 commits intoEmbarkStudios:mainfrom
LykenSol:simple-enums
Conversation
khyperia
approved these changes
Mar 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows simple
enums, likeOption<u32>, to work, since they already have the variant fields in theenumitself(thanks to
ScalarPairABI - but this could easily be extended to at least allOption<T>without much effort).forloops that rely on thoseOptiontypes also work, exceptRange's implementation ofIteratorusesmem::swap, and that happens to have a pretty severe case of microoptimization, that we'll have to turn off upstream (frankly, given that this kind of library optimization blocks MIR optimizations, generating that SIMD loop should probably be done in the backend, not in a library).You can see a working example of a
forloop with a customRange-like iterator, in the third commit.