This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Add a #[spirv(...)] attribute checking pass and remove #[allow(unused_attributes)].#461
Merged
eddyb merged 6 commits intoEmbarkStudios:mainfrom Mar 2, 2021
LykenSol:check-attrs
Merged
Add a #[spirv(...)] attribute checking pass and remove #[allow(unused_attributes)].#461eddyb merged 6 commits intoEmbarkStudios:mainfrom LykenSol:check-attrs
#[spirv(...)] attribute checking pass and remove #[allow(unused_attributes)].#461eddyb merged 6 commits intoEmbarkStudios:mainfrom
LykenSol:check-attrs
Conversation
…sed_attributes)]`.
XAMPPRocky
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By hooking the
check_mod_attrsquery, we can effectively expandrustc_passes::check_attrto also check#[spirv(...)]attributes, which is an improvement over only validating attributes when they happen to be relevant.In particular, this means that now we shouldn't have any latent "we allowed some attribute on an obviously wrong thing" bugs.
It also allows us to mark the attributes as used, and therefore remove the need for
#[allow(unused_attributes)]altogether.Fixes #386 (specifically as suggested in #386 (comment)), to get
spirv_std::storage_class::Imageto compile again.cc @XAMPPRocky It would be nice to get this in the next release, but I understand if we want to wait.