Skip to content
This repository was archived by the owner on Oct 31, 2025. It is now read-only.

Fix wgpu-runner validation errors on minimize#424

Merged
Jasper-Bekkers merged 1 commit intoEmbarkStudios:mainfrom
Hentropy:wgpu-validation-error-fix
Feb 15, 2021
Merged

Fix wgpu-runner validation errors on minimize#424
Jasper-Bekkers merged 1 commit intoEmbarkStudios:mainfrom
Hentropy:wgpu-validation-error-fix

Conversation

@Hentropy
Copy link
Copy Markdown
Contributor

@Hentropy Hentropy commented Feb 14, 2021

Vulkan swap chains must have non-zero dimensions, this adds a check for that during swap chain resizing and does not create one if it would be invalid.

@Hentropy
Fix wgpu-runner validation errors on minimize
50b9022 
Vulkan swap chains must have non-zero dimensions, this adds a check for that during swap chain resizing and does not create one if it would be invalid.
@Hentropy Hentropy mentioned this pull request Feb 14, 2021
Closed
@khyperia
Copy link
Copy Markdown
Contributor

khyperia commented Feb 15, 2021

I can't reproduce any validation errors, is this a platform-specific issue? (what platform are you on?)

@Hentropy
Copy link
Copy Markdown
Contributor Author

Hentropy commented Feb 15, 2021 •
edited
Loading

Oh, I'm on Windows. The swap chain error:

[5.019229 ERROR]()(no module): 
VALIDATION [VUID-VkSwapchainCreateInfoKHR-imageExtent-01689 (320081257)] : Validation Error:
[ VUID-VkSwapchainCreateInfoKHR-imageExtent-01689 ] Object 0: handle = 0x1945c0b4eb8, type = VK_OBJECT_TYPE_DEVICE;
| MessageID = 0x13140d69 | vkCreateSwapchainKHR(): pCreateInfo->imageExtent = (0, 0) which is illegal. The Vulkan spec states:
imageExtent members width and height must both be non-zero
(https://vulkan.lunarg.com/doc/view/1.2.154.1/windows/1.2-extensions/vkspec.html#VUID-VkSwapchainCreateInfoKHR-imageExtent-01689)
object info: (type: DEVICE, hndl: 1736711032504)

There are similar ones for framebuffer creation and setting the viewport as well.

@Jasper-Bekkers Jasper-Bekkers merged commit 45f7a36 into EmbarkStudios:main Feb 15, 2021
@Hentropy Hentropy deleted the wgpu-validation-error-fix branch February 15, 2021 14:59
@khyperia khyperia removed their request for review February 26, 2021 11:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fu5ha fu5ha Awaiting requested review from fu5ha fu5ha is a code owner

1 more reviewer

@VZout VZout VZout approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hentropy @khyperia @VZout @Jasper-Bekkers