This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Remove different OpNames that target the same ID#398
Merged
mergify[bot] merged 1 commit intomainfrom Jan 28, 2021
Merged
Conversation
XAMPPRocky
approved these changes
Jan 28, 2021
Contributor
|
Should we be deduplicating so aggressively? Wouldn't it make more sense to only deduplicate types that connect imports and exports (and therefore must match)? |
Contributor
Author
|
yeah, probably! that gets way more complicated, though, especially because various things in SPIR-V allow duplication, and various other things don't (e.g. you can only have one OpTypeInt of a certain size, but you can have multiple OpTypeStructs that are the same). It's a whole mess that isn't super worth it (especially since even the basic system we have now has known bugs in it). |
eddyb
approved these changes
Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bit of unfortunate interaction in the way we link binaries. Here's an order of operations:
This becomes a problem: things like ZSTs and other extremely common types are emitted a lot, with many different names. They're all merged in step 2, but then we have an absolute heap of names all pointing at the same ID, and that ID happens to be used in a few places, so we barf gazillions of strings into the binary.
So, only keep the first name we encounter for any particular ID. This will likely be the "incorrect" name (probably a name that's actually never used and would have been DCE stripped if we never merged identical constructs), but oh well, that name does correspond to the type, close enough.
This reduces ark's spir-v binary size from 743KiB to 93KiB