This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Merged
Conversation
f8de018 to
a097088
Compare
khyperia
suggested changes
Jan 25, 2021
| /// Calls the `OpDemoteToHelperInvocationEXT` instruction, which corresponds to discard() in HLSL | ||
| #[spirv_std_macros::gpu_only] | ||
| pub fn demote_to_helper_invocation() { | ||
| #[cfg(target_arch = "spirv")] |
Contributor
There was a problem hiding this comment.
just calling out the change of semantics here for others, but I probably don't care either way.
Contributor
|
how does this handle unused argument warnings on the CPU? |
XAMPPRocky
commented
Jan 25, 2021
Comment on lines
+45
to
+46
| // Don't warn on unused arguments on the CPU side. | ||
| #[cfg_attr(not(target_arch = "spirv"), allow(unused_variables))] |
Member
Author
There was a problem hiding this comment.
how does this handle unused argument warnings on the CPU?
It adds allow(unused_variables) when compiled for CPU targets.
khyperia
approved these changes
Jan 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
#[gpu_only]macro tospirv-std-macros, which essentially expands to the following. Which we were doing a lot in the code already, and will only add more in the future.