This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Refactor and document storage classes#280
Merged
mergify[bot] merged 2 commits intomainfrom Nov 27, 2020
Merged
Conversation
khyperia
reviewed
Nov 27, 2020
6f69751 to
eba862f
Compare
XAMPPRocky
commented
Nov 27, 2020
3cc3fdb to
15aca53
Compare
khyperia
approved these changes
Nov 27, 2020
Member
Author
|
I've also now also added a conivence function for "load and store" operations. For example multiplying and storing the result. // Before
input.store(input.load() * 5);
// Now
input.then(|i| i * 5); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how storage classes where defined to their own module, refactors the macro to allow you to define multiple storage classes in a single macro invocation and more importantly allows you to add documentation to the storage classes. With the refactor I also changed the DSL you use to define storage so that's a more descriptive, and hopefully more intuitive, for example here is now what the definition of the
InputandOutputstorage classes look like.