Skip to content
This repository was archived by the owner on Oct 31, 2025. It is now read-only.

Move lang_items into spirv-std#275

Merged
mergify[bot] merged 1 commit intomainfrom
include-lang-items
Nov 26, 2020
Merged

Move lang_items into spirv-std#275
mergify[bot] merged 1 commit intomainfrom
include-lang-items

Conversation

@XAMPPRocky
Copy link
Copy Markdown
Member

This PR moves the lang_items that shader crates need to define into spirv-std itself, so spirv-std behaves a little more like std, and reduces the amount of code you need to get started. It's included under a default feature so if for some reason you still need to define your own lang_items you still can.

@XAMPPRocky XAMPPRocky requested a review from khyperia November 26, 2020 08:47
@XAMPPRocky XAMPPRocky added the s: waiting on review PRs that blocked on a team member's review. label Nov 26, 2020
Copy link
Copy Markdown
Contributor

@khyperia khyperia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat! last time I tried doing this there were absolutely garbage build issues and I gave up, but if it somehow magically works now, 🎉

@mergify mergify bot merged commit 59869ec into main Nov 26, 2020
@mergify mergify bot deleted the include-lang-items branch November 26, 2020 09:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

s: waiting on review PRs that blocked on a team member's review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants