feat: improve error message for incorrect use of DestroyInstance, so it explains that the ArgumentException can be caused by calling that method on the same object more than once

kacper-dudziak-elympics · kacper-dudziak-elympics · commit c8420bda4a8e · 2025-10-23T14:28:03.000+02:00
diff --git a/Runtime/Behaviour/Factory/ElympicsFactory.cs b/Runtime/Behaviour/Factory/ElympicsFactory.cs
@@ -58,7 +58,7 @@ internal void DestroyInstance(GameObject go)
             if (!_playersObjects.TryGetValue(go, out var player))
             {
                 const string message = "Trying to destroy an object not instantiated by Elympics. "
-                    + "This may also be a result of using an incorrectly cached reference after reconciliation.";
+                    + "This may also be a result of using an incorrectly cached reference after reconciliation or trying to destroy the same object more than once.";
                 ElympicsLogger.LogError(message, go);
                 throw new ArgumentException(message, nameof(go));
             }

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ internal void DestroyInstance(GameObject go)`
`58`	`58`	`if (!_playersObjects.TryGetValue(go, out var player))`
`59`	`59`	`{`
`60`	`60`	`const string message = "Trying to destroy an object not instantiated by Elympics. "`
`61`		`- + "This may also be a result of using an incorrectly cached reference after reconciliation.";`
	`61`	`+ + "This may also be a result of using an incorrectly cached reference after reconciliation or trying to destroy the same object more than once.";`
`62`	`62`	`ElympicsLogger.LogError(message, go);`
`63`	`63`	`throw new ArgumentException(message, nameof(go));`
`64`	`64`	`}`