fix: prediction warnings showing incorrect values

kacper-dudziak-elympics · kacper-dudziak-elympics · commit 3d3708637239 · 2026-01-29T16:53:41.000+01:00
When first prediction error was detected, all warnings for the object with incorrect state appearing after the first one could based on incorrect values in some cases
diff --git a/Runtime/Behaviour/ElympicsBehaviour.cs b/Runtime/Behaviour/ElympicsBehaviour.cs
@@ -360,8 +360,12 @@ internal bool AreStatesEqual(byte[] data1, byte[] data2, long tick)
                             ElympicsLogger.LogWarning($"State not equal on field {_backingFieldsNames[backingField]} of {componentName} component attached to {gameObject.name} game object with network ID: {networkId} in history tick {tick}. Last simulated tick: {Elympics.Tick}. State in history: '{difference1}' received state: '{difference2}'.", this);
 #endif
                         areEqual = false;
+                        break;
                     }
                 }
+
+                if (!areEqual)
+                    break;
             }
             _ = _memoryStream1.Seek(0, SeekOrigin.Begin);
             _ = _memoryStream2.Seek(0, SeekOrigin.Begin);

Original file line number	Diff line number	Diff line change
`@@ -360,8 +360,12 @@ internal bool AreStatesEqual(byte[] data1, byte[] data2, long tick)`
`360`	`360`	`ElympicsLogger.LogWarning($"State not equal on field {_backingFieldsNames[backingField]} of {componentName} component attached to {gameObject.name} game object with network ID: {networkId} in history tick {tick}. Last simulated tick: {Elympics.Tick}. State in history: '{difference1}' received state: '{difference2}'.", this);`
`361`	`361`	`#endif`
`362`	`362`	`areEqual = false;`
	`363`	`+ break;`
`363`	`364`	`}`
`364`	`365`	`}`
	`366`	`+`
	`367`	`+ if (!areEqual)`
	`368`	`+ break;`
`365`	`369`	`}`
`366`	`370`	`_ = _memoryStream1.Seek(0, SeekOrigin.Begin);`
`367`	`371`	`_ = _memoryStream2.Seek(0, SeekOrigin.Begin);`