fix: catch unityweb exception

KrzysztofPietaCC · KrzysztofPietaCC · commit 38220fa29f50 · 2025-12-09T13:08:43.000+01:00
diff --git a/Runtime/BehaviourPredefined/Public/NetworkCondition.cs b/Runtime/BehaviourPredefined/Public/NetworkCondition.cs
@@ -20,14 +20,17 @@ public struct NetworkCondition
         /// </summary>
         public long LastReceivedTick;
         /// <summary>
-        /// Weighted Clock Offset in ticks.
+        /// Weighted Local Clock Offset (LCO) in game ticks.
+        ///
+        /// This represents the time difference between the client's local clock and the server's clock,
+        /// smoothed using a running median filter and converted to game ticks.
         /// </summary>
         public double LcoTicks;
         public bool ReconciliationPerformed;
         public double RttTicks;
         public bool WasTickJumpForced;
         public long PredictionLimit;
-        public double DefaultTickRate;
+        public int DefaultTickRate;
         /// <summary>
         /// How many ticks the client had to catch up when a tick jump was forced.
         /// </summary>
diff --git a/Runtime/Communication/HttpSignalingClient.cs b/Runtime/Communication/HttpSignalingClient.cs
@@ -27,17 +27,27 @@ public async UniTask<WebSignalingClientResponse> PostOfferAsync(string offer, Ti
             request.downloadHandler = new DownloadHandlerBuffer();
             request.SetTestCertificateHandlerIfNeeded();
 
-            var (isCanceled, result) = await request.SendWebRequest().ToUniTask(null, PlayerLoopTiming.Update, ct).SuppressCancellationThrow();
-
-            if (isCanceled)
+            try
+            {
+                var (isCanceled, result) = await request.SendWebRequest().ToUniTask(null, PlayerLoopTiming.Update, ct).SuppressCancellationThrow();
+                if (isCanceled)
+                    return new WebSignalingClientResponse
+                    {
+                        IsError = true,
+                        Text = "Operation cancelled.",
+                        Code = 499
+                    };
+                return HandleCompleted(result);
+            }
+            catch (Exception e)
+            {
                 return new WebSignalingClientResponse
                 {
                     IsError = true,
-                    Text = "Operation cancelled.",
-                    Code = 499
+                    Text = e.Message,
+                    Code = 500
                 };
-
-            return HandleCompleted(result);
+            }
         }
 
         public UniTask<WebSignalingClientResponse> OnIceCandidateCreated(string iceCandidate, TimeSpan timeout, string peerId, CancellationToken ct = default) =>
diff --git a/Runtime/Mappers/ClientTickCalculatorNetworkDetailsToNetworkDetailsMapper.cs b/Runtime/Mappers/ClientTickCalculatorNetworkDetailsToNetworkDetailsMapper.cs
@@ -17,7 +17,7 @@ public static NetworkCondition MapToNetworkNetworkCondition(this ClientTickCalcu
                 RttTicks = source.RttTicks,
                 WasTickJumpForced = source.WasTickJumpForced,
                 PredictionLimit = source.PredictionLimit,
-                DefaultTickRate = source.DefaultTickRate,
+                DefaultTickRate = (int)source.DefaultTickRate,
                 TicksToCatchup = source.TicksToCatchup,
                 NewTickFromCalculations = source.NewTickFromCalculations
             };
