[Fix] Support long tensor for DDP backward#146
Merged
nijkah merged 5 commits intoEleutherAI:distributed_data_parallelfrom Mar 3, 2023
Merged
[Fix] Support long tensor for DDP backward#146nijkah merged 5 commits intoEleutherAI:distributed_data_parallelfrom
nijkah merged 5 commits intoEleutherAI:distributed_data_parallelfrom
Conversation
nijkah
reviewed
Mar 3, 2023
Member
|
LGTM @nijkah |
nijkah
reviewed
Mar 3, 2023
Co-authored-by: Hakjin Lee <nijkah@gmail.com>
be987cc to
7a28ee5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #137
For now, our implementation of DDP does not support long tensor input, so I fixed it.