Askrene: fix infinite cost assertion #8832
Merged
+36
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cln-askrene: plugins/askrene/mcf.c:474: combine_cost_function: Assertion `fcost != INFINITE' failed. cln-askrene: FATAL SIGNAL 6 (version v25.12-131-gb15f386-modded) 0x55703f242fd1 send_backtrace common/daemon.c:38 0x55703f24305b crashdump common/daemon.c:83 0x7f548b421def ??? ./signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c:0 0x7f548b47695c __pthread_kill_implementation ./nptl/pthread_kill.c:44 0x7f548b421cc1 __GI_raise ../sysdeps/posix/raise.c:26 0x7f548b40a4ab __GI_abort ./stdlib/abort.c:73 0x7f548b40a41f __assert_fail_base ./assert/assert.c:118 0x55703f234491 combine_cost_function plugins/askrene/mcf.c:474 0x55703f2358b6 single_path_flow plugins/askrene/mcf.c:1213 0x55703f235fa2 linear_routes plugins/askrene/mcf.c:1411 0x55703f236804 single_path_routes plugins/askrene/mcf.c:1656 0x55703f22edad do_getroutes plugins/askrene/askrene.c:689 0x55703f22f269 json_getroutes plugins/askrene/askrene.c:910 0x55703f2411a7 ld_command_handle plugins/libplugin.c:2155 0x55703f2413b1 ld_read_json plugins/libplugin.c:2231 0x55703f271a4d next_plan ccan/ccan/io/io.c:60 0x55703f271ed8 do_plan ccan/ccan/io/io.c:422 0x55703f271f91 io_ready ccan/ccan/io/io.c:439 0x55703f27391b io_loop ccan/ccan/io/poll.c:470 0x55703f2417fd plugin_main plugins/libplugin.c:2429 0x55703f22f753 main plugins/askrene/askrene.c:1452 0x7f548b40bca7 __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 0x7f548b40bd64 __libc_start_main_impl ../csu/libc-start.c:360 0x55703f22baa0 ??? _start+0x20:0 0xffffffffffffffff ??? ???:0 Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Changelog-Fixed: askrene: fix a plugin crash triggered during single path payments when a channel fees doesn't fit u32. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
f417a7b to
6415d29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a plugin crash triggered during single path payments when a channel fees doesn't fit u32.
Addresses one of the assertions mentioned in #8823.