recovery for modern nodes #8830
Merged
+184
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c63e6fb to
e276c02
Compare
We cannot use the codex32 or raw hex for recovery of 25.12 nodes, since they will then use the incorrect derivation for all paths, and be unable to spend (or even find!) their funds. So implement `getsecret` to replace `getcodexsecret`. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Changed: `lightning-hsmtool`: `getsecret` replaces `getcodexsecret` for modern nodes (gives mnemonic). Changelog-Deprecated: `lightning-hsmtool`: `getcodexsecret`. Use `getsecret`.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
In fact, you *must* use mnemonic to successfully recover a modern node! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Changed: JSON-RPC: `recover` takes a 12-word mnemonic for nodes created by v25.12 or later.
e276c02 to
dc3959b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v25.12 introduced a new hsm_secret format, but did not switch the hsmtool or recover commands to support it.
If you "recover" a node created by 25.12 using the codex32 params, YOU WILL NOT SEE ANY IS YOUR FUNDS.
So we fix this: hsmtool now has "getsecret" and you hand that string (whatever it is) to "recover" and it works.