Two payment crashes #8829
Merged
Two payment crashes #8829
+17
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d22cdda to
fb5c666
Compare
Lagrang3
reviewed
Jan 12, 2026
fb5c666 to
9411c18
Compare
9411c18 to
655d368
Compare
Lagrang3
reviewed
Jan 13, 2026
…n max it should have. ``` 1767724611265 2026-01-06T18:36:51.265Z plugins/libplugin.c:1073 1767724611265 2026-01-06T18:36:51.265Z 0x55fc0c1428ac handle_rpc_reply 1767724611264 2026-01-06T18:36:51.264Z plugins/askrene/askrene.c:801 1767724611264 2026-01-06T18:36:51.264Z 0x55fc0c13174c listpeerchannels_done 1767724611264 2026-01-06T18:36:51.264Z plugins/askrene/askrene.c:669 1767724611264 2026-01-06T18:36:51.264Z 0x55fc0c130f55 do_getroutes 1767724611264 2026-01-06T18:36:51.264Z plugins/askrene/mcf.c:1636 1767724611264 2026-01-06T18:36:51.264Z 0x55fc0c138bd7 default_routes 1767724611264 2026-01-06T18:36:51.264Z plugins/askrene/mcf.c:1415 1767724611264 2026-01-06T18:36:51.264Z 0x55fc0c1382ec linear_routes 1767724611264 2026-01-06T18:36:51.264Z plugins/askrene/refine.c:510 1767724611264 2026-01-06T18:36:51.264Z 0x55fc0c13b110 refine_flows 1767724611264 2026-01-06T18:36:51.264Z plugins/askrene/refine.c:449 1767724611264 2026-01-06T18:36:51.264Z 0x55fc0c13ac9f increase_flows 1767724611264 2026-01-06T18:36:51.264Z abort+0xde:0 ``` Fixes: ElementsProject#8823 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: plugins: `askrene` can crash on a corner case in increase_flows.
I assume this happens with multi-hop routehints? ``` 1768169599027 2026-01-11T22:13:19.027Z pay: plugins/libplugin-pay.c:1199: payment_result_infer: Assertion `i <= len' failed. 1768169599027 2026-01-11T22:13:19.027Z pay: FATAL SIGNAL 6 (version 25.12) 1768169599036 2026-01-11T22:13:19.036Z 0x5562816bcaa4 send_backtrace 1768169599036 2026-01-11T22:13:19.036Z common/daemon.c:38 1768169599036 2026-01-11T22:13:19.036Z 0x5562816bcb40 crashdump 1768169599036 2026-01-11T22:13:19.036Z common/daemon.c:83 1768169599036 2026-01-11T22:13:19.036Z 0x7f5fca29d32f ??? 1768169599036 2026-01-11T22:13:19.036Z ???:0 1768169599036 2026-01-11T22:13:19.036Z 0x7f5fca2f6b2c ??? 1768169599036 2026-01-11T22:13:19.036Z pthread_kill+0x11c:0 1768169599036 2026-01-11T22:13:19.036Z 0x7f5fca29d27d ??? 1768169599036 2026-01-11T22:13:19.036Z gsignal+0x1d:0 1768169599036 2026-01-11T22:13:19.036Z 0x7f5fca2808fe ??? 1768169599036 2026-01-11T22:13:19.036Z abort+0xde:0 1768169599036 2026-01-11T22:13:19.036Z 0x7f5fca28081a ??? 1768169599036 2026-01-11T22:13:19.036Z ???:0 1768169599036 2026-01-11T22:13:19.036Z 0x7f5fca293516 ??? 1768169599036 2026-01-11T22:13:19.036Z __assert_fail+0x46:0 1768169599037 2026-01-11T22:13:19.037Z 0x5562816ae9f6 payment_result_infer 1768169599037 2026-01-11T22:13:19.037Z plugins/libplugin-pay.c:1199 1768169599037 2026-01-11T22:13:19.037Z 0x5562816b4acd payment_waitsendpay_finished 1768169599037 2026-01-11T22:13:19.037Z plugins/libplugin-pay.c:1653 1768169599037 2026-01-11T22:13:19.037Z 0x5562816aca60 handle_rpc_reply 1768169599037 2026-01-11T22:13:19.037Z plugins/libplugin.c:1062 1768169599037 2026-01-11T22:13:19.037Z 0x5562816acc86 rpc_conn_read_response 1768169599037 2026-01-11T22:13:19.037Z plugins/libplugin.c:1377 1768169599037 2026-01-11T22:13:19.037Z 0x5562816f0e87 next_plan 1768169599037 2026-01-11T22:13:19.037Z ccan/ccan/io/io.c:60 1768169599037 2026-01-11T22:13:19.037Z 0x5562816f1358 do_plan 1768169599037 2026-01-11T22:13:19.037Z ccan/ccan/io/io.c:422 1768169599037 2026-01-11T22:13:19.037Z 0x5562816f1415 io_ready 1768169599037 2026-01-11T22:13:19.037Z ccan/ccan/io/io.c:439 1768169599037 2026-01-11T22:13:19.037Z 0x5562816f2e23 io_loop 1768169599037 2026-01-11T22:13:19.037Z ccan/ccan/io/poll.c:470 1768169599037 2026-01-11T22:13:19.037Z 0x5562816ae114 plugin_main 1768169599037 2026-01-11T22:13:19.037Z plugins/libplugin.c:2429 1768169599037 2026-01-11T22:13:19.037Z 0x5562816a894c main 1768169599037 2026-01-11T22:13:19.037Z plugins/pay.c:1581 1768169599037 2026-01-11T22:13:19.037Z 0x7f5fca2821c9 ??? 1768169599037 2026-01-11T22:13:19.037Z ???:0 1768169599037 2026-01-11T22:13:19.037Z 0x7f5fca28228a ??? 1768169599037 2026-01-11T22:13:19.037Z __libc_start_main+0x8a:0 1768169599037 2026-01-11T22:13:19.037Z 0x5562816a4eb4 ??? 1768169599037 2026-01-11T22:13:19.037Z _start+0x24:0 1768169599037 2026-01-11T22:13:19.037Z 0xffffffffffffffff ??? 1768169599037 2026-01-11T22:13:19.037Z ???:0 1768169599136 2026-01-11T22:13:19.136Z 2026-01-11T22:13:19.136Z INFO plugin-pay: Killing plugin: exited during normal operation 69599136 2026-01-11T22:13:19.136Z 2026-01-11T22:13:19.136Z **BROKEN** plugin-pay: Plugin marked as important, shutting down lightningd! ``` Reported-by: michael1011 Fixes: ElementsProject#8828 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: plugins: `pay` can crash on errors returned from deep inside routehints.
655d368 to
3d992ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't fix them, I just stopped them from crashing the node.