We do wait for bitcoind on startup indefinitely, if it its at least on warmup:

Lines 817 to 871 in 483579f

    
           static void wait_and_check_bitcoind(struct plugin *p) 
        
           { 
        
           	int from, status, ret; 
        
           	pid_t child; 
        
           	const char **cmd = gather_args(bitcoind, "getnetworkinfo", NULL); 
        
           	bool printed = false; 
        
           	char *output = NULL; 
        
           	for (;;) { 
        
           		tal_free(output); 
        
           		child = pipecmdarr(NULL, &from, &from, cast_const2(char **,cmd)); 
        
           		if (child < 0) { 
        
           			if (errno == ENOENT) 
        
           				bitcoind_failure(p, "bitcoin-cli not found. Is bitcoin-cli " 
        
           						    "(part of Bitcoin Core) available in your PATH?"); 
        
           			plugin_err(p, "%s exec failed: %s", cmd[0], strerror(errno)); 
        
           		} 
        
           		output = grab_fd(cmd, from); 
        
           		while ((ret = waitpid(child, &status, 0)) < 0 && errno == EINTR); 
        
           		if (ret != child) 
        
           			bitcoind_failure(p, tal_fmt(bitcoind, "Waiting for %s: %s", 
        
           						    cmd[0], strerror(errno))); 
        
           		if (!WIFEXITED(status)) 
        
           			bitcoind_failure(p, tal_fmt(bitcoind, "Death of %s: signal %i", 
        
           						   cmd[0], WTERMSIG(status))); 
        
           		if (WEXITSTATUS(status) == 0) 
        
           			break; 
        
           		/* bitcoin/src/rpc/protocol.h: 
        
           		 *	RPC_IN_WARMUP = -28, //!< Client still warming up 
        
           		 */ 
        
           		if (WEXITSTATUS(status) != 28) { 
        
           			if (WEXITSTATUS(status) == 1) 
        
           				bitcoind_failure(p, "Could not connect to bitcoind using" 
        
           						    " bitcoin-cli. Is bitcoind running?"); 
        
           			bitcoind_failure(p, tal_fmt(bitcoind, "%s exited with code %i: %s", 
        
           						    cmd[0], WEXITSTATUS(status), output)); 
        
           		} 
        
           		if (!printed) { 
        
           			plugin_log(p, LOG_UNUSUAL, 
        
           				   "Waiting for bitcoind to warm up..."); 
        
           			printed = true; 
        
           		} 
        
           		sleep(1); 
        
           	} 
        
           	parse_getnetworkinfo_result(p, output); 
        
           	tal_free(cmd); 
        
           }

From your error in #4352 (comment) it looks like bitcoind has not even be started yet, and i'm not sure it's reasonable to wait with no clue that a bitcoind is actually going to start behind us at some point?

	static void wait_and_check_bitcoind(struct plugin *p)
	{
	int from, status, ret;
	pid_t child;
	const char **cmd = gather_args(bitcoind, "getnetworkinfo", NULL);
	bool printed = false;
	char *output = NULL;

	for (;;) {
	tal_free(output);

	child = pipecmdarr(NULL, &from, &from, cast_const2(char **,cmd));
	if (child < 0) {
	if (errno == ENOENT)
	bitcoind_failure(p, "bitcoin-cli not found. Is bitcoin-cli "
	"(part of Bitcoin Core) available in your PATH?");
	plugin_err(p, "%s exec failed: %s", cmd[0], strerror(errno));
	}

	output = grab_fd(cmd, from);

	while ((ret = waitpid(child, &status, 0)) < 0 && errno == EINTR);
	if (ret != child)
	bitcoind_failure(p, tal_fmt(bitcoind, "Waiting for %s: %s",
	cmd[0], strerror(errno)));
	if (!WIFEXITED(status))
	bitcoind_failure(p, tal_fmt(bitcoind, "Death of %s: signal %i",
	cmd[0], WTERMSIG(status)));

	if (WEXITSTATUS(status) == 0)
	break;

	/* bitcoin/src/rpc/protocol.h:
	* RPC_IN_WARMUP = -28, //!< Client still warming up
	*/
	if (WEXITSTATUS(status) != 28) {
	if (WEXITSTATUS(status) == 1)
	bitcoind_failure(p, "Could not connect to bitcoind using"
	" bitcoin-cli. Is bitcoind running?");
	bitcoind_failure(p, tal_fmt(bitcoind, "%s exited with code %i: %s",
	cmd[0], WEXITSTATUS(status), output));
	}

	if (!printed) {
	plugin_log(p, LOG_UNUSUAL,
	"Waiting for bitcoind to warm up...");
	printed = true;
	}
	sleep(1);
	}

	parse_getnetworkinfo_result(p, output);

	tal_free(cmd);
	}

[Feature request] Wait a while for Bitcoin Core to start instead of crashing immediately #4355

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions