Patch bip32_key_unserialize and add tests for TV5#521
Closed
kuliq23 wants to merge 1 commit intoElementsProject:masterfrom
Closed
Patch bip32_key_unserialize and add tests for TV5#521kuliq23 wants to merge 1 commit intoElementsProject:masterfrom
kuliq23 wants to merge 1 commit intoElementsProject:masterfrom
Conversation
Contributor
Contributor
|
Merged under #522, closing thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should add BIP32 Test Vector 5 to
src/test/test_bip32.pyand provide corresponding checks insrc/bip32.csrc/test/test_bip32.py(in the simplest way possible, feel free to refactor)is_valid_keywith sufficient checks relevant to TV5 casesis_valid_keyfunction call to the end ofbip32_key_unserializeAll tests pass.
Found through differential fuzzing using bitcoinfuzz
Reported in PR466