Skip to content

feat(token): add taxonomy-backed missing-kid negative#832

Merged
EffortlessSteven merged 1 commit into
mainfrom
feat/token-shape-negatives
May 18, 2026
Merged

feat(token): add taxonomy-backed missing-kid negative#832
EffortlessSteven merged 1 commit into
mainfrom
feat/token-shape-negatives

Conversation

@EffortlessSteven

Copy link
Copy Markdown
Member

Summary

  • add NegativeToken::MissingKid for deterministic JWT-shaped missing-header-kid fixtures
  • add NegativeToken::stable_id() values that align token negatives with SPEC-0016 taxonomy IDs
  • cover the new public TokenFixture::negative_value path, README example, and failure atlas row
  • advance the real workflow goal to the OIDC/JWKS validator example slice

User path

Rust developers can request a deterministic missing-kid JWT-shaped negative through the token fixture API, then use it to exercise verifier rejection paths without changing positive token fixtures.

Boundary

This does not change positive token derivation, OIDC bundle layout, provider compatibility claims, production security claims, or scanner-evasion posture.

Proof

  • cargo test -p uselesskey-token --all-features
  • cargo test -p uselesskey --all-features
  • cargo fmt --all -- --check
  • cargo +nightly xtask pr-lite
  • git diff --check

Receipts

NegativeToken::stable_id() now exposes taxonomy-backed IDs, and tests cover the missing-kid token shape, deterministic output, positive cache isolation, and distinct negative output.

Risk

This adds a public enum variant and public helper method. Existing variant_name() strings and positive token fixture identity are unchanged.

Rollback

The PR can be reverted independently before the OIDC/JWKS validator workflow consumes the missing-kid negative.

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minute and 47 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 45ad2a47-8903-446f-80e3-fb375cab81aa

📥 Commits

Reviewing files that changed from the base of the PR and between c8516fa and 8ff1350.

📒 Files selected for processing (5)
  • .uselesskey/goals/active.toml
  • crates/uselesskey-token/README.md
  • crates/uselesskey-token/src/srp/shape.rs
  • crates/uselesskey-token/tests/negative_value_variants.rs
  • docs/reference/failure-atlas.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/token-shape-negatives

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EffortlessSteven EffortlessSteven merged commit f0152cb into main May 18, 2026
6 checks passed
@EffortlessSteven EffortlessSteven deleted the feat/token-shape-negatives branch May 18, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant