Skip to content

feat(jwk): add taxonomy-backed negative fixtures#831

Merged
EffortlessSteven merged 2 commits into
mainfrom
feat/jwk-jwks-negative-fixtures
May 18, 2026
Merged

feat(jwk): add taxonomy-backed negative fixtures#831
EffortlessSteven merged 2 commits into
mainfrom
feat/jwk-jwks-negative-fixtures

Conversation

@EffortlessSteven

Copy link
Copy Markdown
Member

Summary

  • add taxonomy stable IDs for NegativeJwk and NegativeJwks
  • add explicit MalformedBase64url naming while keeping MalformedField as the compatibility path for the same generated shape
  • add NegativeJwks::MixedValidInvalid for a realistic key-set negative containing one valid key and one malformed key
  • update tests and README coverage, then advance the lane goal to the token-shape negative wave

User path

Rust developers can now generate and name taxonomy-backed JWK/JWKS negative fixtures for downstream parser/verifier tests without hand-rolling broken key shapes.

Boundary

This does not add an OIDC provider compatibility claim, change contract-pack files, add production security claims, or change existing positive fixture derivation.

Proof

  • cargo test -p uselesskey-jwk --all-features
  • cargo test -p uselesskey --all-features
  • cargo +nightly xtask pr-lite
  • git diff --check

Receipts

  • NegativeJwk::stable_id() / NegativeJwks::stable_id() expose SPEC-0016 names
  • JWK tests cover the stable IDs and mixed valid/invalid JWKS shape

Risk

This adds public enum surface for a new JWKS negative and a named malformed-base64url variant. Existing generated negative values and positive deterministic fixture identity are unchanged.

Rollback

This PR can be reverted independently; later token and bundle work should continue from SPEC-0016 without relying on this branch until merged.

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 41 minutes and 49 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 39805a3e-0b3a-44ae-9f45-1155ba39b0e0

📥 Commits

Reviewing files that changed from the base of the PR and between f0a23da and 4610a7b.

📒 Files selected for processing (4)
  • .uselesskey/goals/active.toml
  • crates/uselesskey-jwk/README.md
  • crates/uselesskey-jwk/src/srp/shape.rs
  • crates/uselesskey-jwk/tests/jwk_extra_coverage.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/jwk-jwks-negative-fixtures

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EffortlessSteven EffortlessSteven merged commit c8516fa into main May 18, 2026
6 checks passed
@EffortlessSteven EffortlessSteven deleted the feat/jwk-jwks-negative-fixtures branch May 18, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant