Skip to content

test(core): strengthen deterministic_from_str unit coverage#825

Merged
EffortlessSteven merged 1 commit into
mainfrom
codex/improve-unit-testing-9yesku
May 19, 2026
Merged

test(core): strengthen deterministic_from_str unit coverage#825
EffortlessSteven merged 1 commit into
mainfrom
codex/improve-unit-testing-9yesku

Conversation

@EffortlessSteven

@EffortlessSteven EffortlessSteven commented May 18, 2026

Copy link
Copy Markdown
Member

Motivation

  • Improve confidence in deterministic seed construction semantics for Factory::deterministic_from_str by exercising whitespace handling and parity with Seed::from_text in unit tests.

Description

  • Added two unit tests to crates/uselesskey-core/src/srp/factory.rs: deterministic_from_str_preserves_whitespace to assert surrounding whitespace is significant, and deterministic_from_str_matches_seed_from_text to assert equivalence with Factory::deterministic(Seed::from_text(...)).

Testing

  • Ran cargo test -p uselesskey-core deterministic_from_ and both new tests (deterministic_from_str_preserves_whitespace and deterministic_from_str_matches_seed_from_text) passed; the package test run completed successfully.

Codex Task

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented May 18, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 54 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 80bb480a-8f40-4670-9291-80fd8a1fcbb6

📥 Commits

Reviewing files that changed from the base of the PR and between 77f9f0b and 7c7494f.

📒 Files selected for processing (1)
  • crates/uselesskey-core/src/srp/factory.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/improve-unit-testing-9yesku

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

gemini-code-assist Bot commented May 18, 2026

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@EffortlessSteven EffortlessSteven merged commit a5fce65 into main May 19, 2026
7 checks passed
@EffortlessSteven EffortlessSteven deleted the codex/improve-unit-testing-9yesku branch May 19, 2026 01:44
@EffortlessSteven EffortlessSteven mentioned this pull request May 19, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EffortlessSteven