Skip to content

test(core): add PEM corruption edge-case coverage#822

Merged
EffortlessSteven merged 2 commits into
mainfrom
codex/improve-code-coverage-q0graq
May 19, 2026
Merged

test(core): add PEM corruption edge-case coverage#822
EffortlessSteven merged 2 commits into
mainfrom
codex/improve-code-coverage-q0graq

Conversation

@EffortlessSteven

@EffortlessSteven EffortlessSteven commented May 18, 2026

Copy link
Copy Markdown
Member

Motivation

  • Improve unit test coverage for PEM negative-fixture helpers to exercise empty-input and UTF-8 truncation edge cases and reduce uncovered branches in corrupt_pem behavior.

Description

  • Add three unit tests in crates/uselesskey-core/src/srp/negative/pem.rs to cover: CorruptPem::BadHeader on empty input, UTF-8 truncation when the byte budget lands exactly on a multi-byte character boundary, and zero-byte truncation returning an empty string.

Testing

  • Ran cargo test -p uselesskey-core negative::pem -- --nocapture and the test suite completed successfully with 28 passed; 0 failed for the targeted tests.

Codex Task

@gemini-code-assist

gemini-code-assist Bot commented May 18, 2026

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented May 18, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 58 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 537ab2a9-0832-48b9-9e5e-c88e9c38f5fd

📥 Commits

Reviewing files that changed from the base of the PR and between 77f9f0b and b68f85d.

📒 Files selected for processing (1)
  • crates/uselesskey-core/src/srp/negative/pem.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/improve-code-coverage-q0graq

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EffortlessSteven EffortlessSteven merged commit 3d279a2 into main May 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EffortlessSteven