Skip to content

test(webauthn): improve coverage for JSON payload and length-prefix boundary#821

Merged
EffortlessSteven merged 2 commits into
mainfrom
codex/improve-code-coverage-7u4qnf
May 19, 2026
Merged

test(webauthn): improve coverage for JSON payload and length-prefix boundary#821
EffortlessSteven merged 2 commits into
mainfrom
codex/improve-code-coverage-7u4qnf

Conversation

@EffortlessSteven

@EffortlessSteven EffortlessSteven commented May 18, 2026

Copy link
Copy Markdown
Member

Motivation

  • Improve unit test coverage for WebAuthn fixture shape generation and exercise an edge case in write_field length-prefix encoding to prevent regressions.

Description

  • Add two tests in crates/uselesskey-webauthn/src/lib.rs: one verifying build_client_data_json encodes type, origin, base64url challenge, and crossOrigin: false, and another asserting write_field uses the 2-byte u16 prefix when the value length is exactly u16::MAX.

Testing

  • Ran cargo test -p uselesskey-webauthn and all tests passed (22 passed; 0 failed).

Codex Task

@gemini-code-assist

gemini-code-assist Bot commented May 18, 2026

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented May 18, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 58 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 57740cfa-0064-496b-96a4-38776099b212

📥 Commits

Reviewing files that changed from the base of the PR and between 77f9f0b and 4a856d1.

📒 Files selected for processing (1)
  • crates/uselesskey-webauthn/src/lib.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/improve-code-coverage-7u4qnf

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EffortlessSteven EffortlessSteven merged commit 11de6ee into main May 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EffortlessSteven