Skip to content

Improve proptest distinct-label generation in ECDSA property tests#815

Merged
EffortlessSteven merged 1 commit into
mainfrom
codex/improve-proptesting-wrvwvq
May 19, 2026
Merged

Improve proptest distinct-label generation in ECDSA property tests#815
EffortlessSteven merged 1 commit into
mainfrom
codex/improve-proptesting-wrvwvq

Conversation

@EffortlessSteven

Copy link
Copy Markdown
Member

Motivation

  • Replace assumption-based input rejection in a proptest with a generator that yields only valid (distinct) label pairs to make the property clearer and avoid runtime prop_assume! filtering.

Description

  • Add a distinct_labels() helper that returns a (String, String) pair strategy and uses .prop_filter() to ensure the two labels differ.
  • Gate the helper with #[cfg(feature = "jwk")] to avoid dead-code warnings when the jwk feature is not enabled.
  • Update the different_labels_produce_different_kids property to consume (label1, label2) in distinct_labels() and remove the inline prop_assume!.

Testing

  • Ran cargo test -p uselesskey-ecdsa --test ecdsa_prop and the proptest suite completed successfully (4 passed; 0 failed).

Codex Task

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 33 minutes and 26 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f23849e9-94bb-4127-aeeb-e73272135804

📥 Commits

Reviewing files that changed from the base of the PR and between 77f9f0b and 51aa5a6.

📒 Files selected for processing (1)
  • crates/uselesskey-ecdsa/tests/ecdsa_prop.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/improve-proptesting-wrvwvq

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EffortlessSteven EffortlessSteven merged commit ab37146 into main May 19, 2026
7 checks passed
@EffortlessSteven EffortlessSteven deleted the codex/improve-proptesting-wrvwvq branch May 19, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant