Skip to content

Strengthen core proptests for seed parsing and cache semantics#814

Merged
EffortlessSteven merged 1 commit into
mainfrom
codex/improve-proptesting-mghie2
May 19, 2026
Merged

Strengthen core proptests for seed parsing and cache semantics#814
EffortlessSteven merged 1 commit into
mainfrom
codex/improve-proptesting-mghie2

Conversation

@EffortlessSteven

Copy link
Copy Markdown
Member

Motivation

  • Tighten property-test coverage around seed parsing to ensure ambiguous 64-byte inputs are handled strictly.
  • Make cache semantics explicit in tests by verifying pointer identity behavior across cache clears while preserving deterministic values.

Description

  • Add a proptest seed_from_env_value_invalid_64_byte_hex_is_err that generates 64-char non-hex payloads and asserts Seed::from_env_value returns Err for raw, 0x-prefixed, and 0X-prefixed forms.
  • Extend prop_cache_hit_returns_same_arc to call fx.clear_cache() and assert the cached Arc pointer is replaced while the dereferenced deterministic value remains equal.
  • Tests live in crates/uselesskey-core/tests/core_prop.rs and use existing proptest helpers and generators.

Testing

  • Ran cargo test -p uselesskey-core --test core_prop, which executed the updated proptests.
  • All tests in that test target passed (17 passed, 0 failed).

Codex Task

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 33 minutes and 33 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4230f3bd-a436-4a38-906a-1f5cc94d9cf5

📥 Commits

Reviewing files that changed from the base of the PR and between 77f9f0b and d14186e.

📒 Files selected for processing (1)
  • crates/uselesskey-core/tests/core_prop.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/improve-proptesting-mghie2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EffortlessSteven EffortlessSteven merged commit b63fbdd into main May 19, 2026
7 checks passed
@EffortlessSteven EffortlessSteven deleted the codex/improve-proptesting-mghie2 branch May 19, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant