Skip to content

Improve core proptest cache coverage#813

Merged
EffortlessSteven merged 2 commits into
mainfrom
codex/improve-proptesting-tiourn
May 19, 2026
Merged

Improve core proptest cache coverage#813
EffortlessSteven merged 2 commits into
mainfrom
codex/improve-proptesting-tiourn

Conversation

@EffortlessSteven

Copy link
Copy Markdown
Member

Motivation

  • Strengthen property-based coverage around the core factory cache to catch regressions where determinism could accidentally depend on insertion order, cache state, or request ordering.
  • Exercise a broader space of artifact identities (domain, label, spec, variant) in proptest traces to increase confidence that cache and derivation invariants hold under arbitrary operation sequences.

Description

  • Add a CacheOp model and cache_op_strategy() to generate arbitrary cache operation traces varying domain, label, spec, and variant in crates/uselesskey-core/tests/core_prop.rs.
  • Add a reusable materialize_ops(seed, ops) helper that drives a deterministic Factory through a sequence of CacheOps and records the observed derived bytes in a BTreeMap.
  • Add a new trace-level proptest prop_arbitrary_cache_traces_are_order_and_cache_independent that validates outputs are stable across duplicate requests, cache clears, fresh factories, and canonical replay ordering.
  • Import BTreeMap and wire the new helpers into the existing core_prop.rs proptest suite without changing existing assertions.

Testing

  • Ran cargo test -p uselesskey-core --test core_prop and all tests passed (17 passed; 0 failed).
  • The new property (prop_arbitrary_cache_traces_are_order_and_cache_independent) executes as part of core_prop and succeeded in the test run.

Codex Task

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 17 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2c4668a0-2714-4b8a-a89e-1337941979cb

📥 Commits

Reviewing files that changed from the base of the PR and between 77f9f0b and 45591a1.

📒 Files selected for processing (1)
  • crates/uselesskey-core/tests/core_prop.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/improve-proptesting-tiourn

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EffortlessSteven EffortlessSteven merged commit 354c3db into main May 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant