Skip to content

test(core): strengthen proptest coverage and reduce rejects#812

Merged
EffortlessSteven merged 1 commit into
mainfrom
codex/improve-proptesting
May 19, 2026
Merged

test(core): strengthen proptest coverage and reduce rejects#812
EffortlessSteven merged 1 commit into
mainfrom
codex/improve-proptesting

Conversation

@EffortlessSteven

Copy link
Copy Markdown
Member

Motivation

  • Broaden proptest coverage for the core_prop module to detect more edge cases per run by increasing the case count.
  • Reduce wasted/fragile proptest runs caused by local prop_assume! filters that reject generated examples, making tests more efficient and stable.

Description

  • Add a module-level proptest configuration #![proptest_config(ProptestConfig { cases: 96, ..ProptestConfig::default() })] to crates/uselesskey-core/tests/core_prop.rs to increase per-run sample counts.
  • Replace prop_assume!(label1 != label2) and prop_assume!(variant1 != variant2) with normalization logic that ensures the second generated value differs (e.g. let label2 = if label1 == label2 { format!("{}x", label2) } else { label2 };).
  • Limit changes to test-only code and preserve original assertions and intent.

Testing

  • Ran cargo test -p uselesskey-core --test core_prop, which completed successfully with all tests passing.

Codex Task

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 33 minutes and 49 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f467add3-42c5-47c1-8126-80b858a28901

📥 Commits

Reviewing files that changed from the base of the PR and between 77f9f0b and 025d3ac.

📒 Files selected for processing (1)
  • crates/uselesskey-core/tests/core_prop.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/improve-proptesting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EffortlessSteven EffortlessSteven merged commit 7b36b6a into main May 19, 2026
7 checks passed
@EffortlessSteven EffortlessSteven deleted the codex/improve-proptesting branch May 19, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant