xtask: test downstream CI recipes#798
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces a new --ci-recipes flag to the external-adoption-smoke command, enabling an explicit opt-in mode to verify downstream CI workflows. The implementation includes a sequence of bundle, verify-bundle, and audit-bundle --ci commands for the webhook, tls, and oidc profiles, along with updated documentation and CLI tests. Feedback suggests including the scanner-safe profile in the CI_RECIPE_PROFILES constant to ensure all supported workflows are covered by the smoke test.
| const REPORT_MD: &str = "target/external-adoption-smoke/report.md"; | ||
|
|
||
| const CLI_PROFILES: &[&str] = &["scanner-safe", "tls", "oidc", "webhook"]; | ||
| const CI_RECIPE_PROFILES: &[&str] = &["webhook", "tls", "oidc"]; |
There was a problem hiding this comment.
The CI_RECIPE_PROFILES constant excludes the scanner-safe profile, which is present in CLI_PROFILES. While the PR description focuses on webhook, TLS, and OIDC, the scanner-safe profile also supports the audit-bundle --ci workflow. If the intent is to test the documented downstream CI recipes for all supported profiles, consider including scanner-safe here as well.
const CI_RECIPE_PROFILES: &[&str] = &["scanner-safe", "webhook", "tls", "oidc"];
Summary
cargo xtask external-adoption-smoke --ci-recipesmode.audit-bundle --ci.ci_recipesin the external-adoption smoke receipt and keeps default external smoke /adoption-regression --externalbounded.Files added/changed
xtask/src/external_adoption_smoke.rsxtask/src/main.rsxtask/src/adoption_regression.rsdocs/specs/USELESSKEY-SPEC-0013-external-adoption-smoke.md.uselesskey/goals/active.tomlValidation
cargo test -p xtask external_adoption_smoke --no-runcargo test -p xtask external_adoption_smokecargo xtask external-adoption-smoke --path . --ci-recipes --format jsoncargo xtask adoption-regression --externalcargo xtask docs-sync --checkcargo xtask typoscargo +nightly xtask pr-litegit diff --checkNon-goals
What this enables next