Skip to content

test(x509): tolerate CRLF blank-line corruption#790

Merged
EffortlessSteven merged 1 commit into
mainfrom
test/x509-crlf-blank-line
May 18, 2026
Merged

test(x509): tolerate CRLF blank-line corruption#790
EffortlessSteven merged 1 commit into
mainfrom
test/x509-crlf-blank-line

Conversation

@EffortlessSteven

@EffortlessSteven EffortlessSteven commented May 18, 2026

Copy link
Copy Markdown
Member

Summary

  • Normalize CRLF to LF in the ExtraBlankLine PEM corruption assertion so Windows line endings do not hide the intended blank-line check.

Files changed

  • crates/uselesskey-x509/tests/negative_x509.rs

Validation

  • cargo test -p uselesskey-x509 --test negative_x509 corrupt_cert_pem_extra_blank_line_on_real_cert

Non-goals

  • No fixture behavior change.
  • No release, badge, or contract-pack changes.

What this enables next

  • Keeps adoption-regression / X.509 negative fixture checks portable while the installed bundle audit lane lands separately.

@gemini-code-assist

gemini-code-assist Bot commented May 18, 2026

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented May 18, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 31 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4c0c34f3-a9b5-411d-ad16-dcef4b81f3d7

📥 Commits

Reviewing files that changed from the base of the PR and between 7f8dd49 and b210f69.

📒 Files selected for processing (1)
  • crates/uselesskey-x509/tests/negative_x509.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/x509-crlf-blank-line

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EffortlessSteven EffortlessSteven merged commit 5186314 into main May 18, 2026
6 checks passed
@EffortlessSteven EffortlessSteven deleted the test/x509-crlf-blank-line branch May 18, 2026 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EffortlessSteven