Guard factory initialization concurrency#781
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Motivation
Factory::get_or_initfor the same(domain, label, spec, variant)identity.Description
std-gatedInitLocks(backed byMutex<BTreeSet<ArtifactId>>and aCondvar) and anInitGuardtype, and wire aninit_locksfield intoInnerto coordinate per-artifact initialization.Factory::get_or_init(init_locks.acquire(&id)) and re-check the cache after acquiring the guard so waiters return the already-cached value instead of duplicating work.concurrent_same_identity_runs_initializer_oncedemonstrating eight simultaneous callers run the initializer exactly once and receive the same cachedArc.Testing
cargo test -p uselesskey-core concurrent_same_identity_runs_initializer_once --liband it passed.cargo test -p uselesskey-core --liband the full unit test suite passed (129 passed; 0 failed).cargo check -p uselesskey-core --no-default-featuresand it completed successfully.cargo clippy -p uselesskey-core --all-targets -- -D warningsand the crate passed clippy checks; also ran the workspace lint fixes (cargo xtask lint-fix) to apply formatting whencargo xtask lint-fix --checkinitially flagged a formatting diff.Codex Task