Harden seed parsing edge cases#779
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Motivation
Seed::from_env_valuecorrectly treats short or invalid-length0x-prefixed inputs as ordinary text rather than attempting to parse them as 64-char hex, closing a deterministic-derivation footgun for oddly formatted env seeds.Description
hex_seed_candidateand simplifySeed::from_env_valueto use it (file:crates/uselesskey-core/src/srp/seed.rs).parse_hex_32behavior unchanged.0x-prefixed strings and0x-prefixed invalid-length hex strings are hashed as ordinary input.Testing
cargo test -q -p uselesskey-core srp::seed::testsand the targeted tests passed successfully.cargo test -q -p uselesskey-coreand alluselesskey-coretests passed successfully.cargo clippy -q -p uselesskey-core --all-targets -- -D warningsand lint checks passed with no warnings.Codex Task