Deduplicate PKCS#8/SPKI keypair accessors via shared macro#771
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Motivation
kidmethods, creating duplication and maintenance burden.Description
impl_pkcs8_spki_fixture_accessors!()incrates/uselesskey-core/src/srp/keypair_material.rsthat generates the common accessors, tempfile writers, corruption helpers, mismatched-public-helper, and thekidaccessor.crates/uselesskey-rsa/src/keypair.rs,crates/uselesskey-ecdsa/src/keypair.rs, andcrates/uselesskey-ed25519/src/keypair.rswith a single invocation of the new macro.uselines.Pkcs8SpkiKeyMaterialAPI intact and reuse its methods from the macro, preserving behavior and doc examples.Testing
cargo check -p uselesskey-rsa -p uselesskey-ecdsa -p uselesskey-ed25519 --all-featuresand it completed successfully.cargo xtask lint-fix --check --no-clippyandcargo clippy -p uselesskey-core -p uselesskey-rsa -p uselesskey-ecdsa -p uselesskey-ed25519 --all-features -- -D warningswith no warnings or failures.cargo test -p uselesskey-core -p uselesskey-rsa -p uselesskey-ecdsa -p uselesskey-ed25519 --all-featuresand all tests passed.fuzz/Cargo.lockpre-existed and was not included in this change set.Codex Task