Skip to content

fix(x509): remove self-signed generation panic debt#732

Merged
EffortlessSteven merged 1 commit into
mainfrom
policy/no-panic-baseline-x509-refactor
May 16, 2026
Merged

fix(x509): remove self-signed generation panic debt#732
EffortlessSteven merged 1 commit into
mainfrom
policy/no-panic-baseline-x509-refactor

Conversation

@EffortlessSteven

Copy link
Copy Markdown
Member

Summary

  • Removes the self-signed X.509 production-path expect sites that became new no-panic debt after the SRP split.
  • Keeps normal valid-input generation behavior intact while making the non-fallible self-signed path avoid panicking on invalid DNS SAN input.
  • Refreshes the no-panic baseline after the removed X.509 expect sites disappeared.

Files added/changed

  • crates/uselesskey-x509/src/cert.rs
  • crates/uselesskey-x509/src/cert/material.rs
  • crates/uselesskey-x509/src/cert/params.rs
  • policy/no-panic-baseline.toml

Validation

  • cargo xtask fmt
  • cargo test -p uselesskey-x509 invalid_dns_san_does_not_block_self_signed_generation --all-features
  • cargo test -p uselesskey-x509 --all-features
  • cargo clippy -p uselesskey-x509 --all-targets --all-features -- -D warnings
  • cargo xtask check-no-panic-family
  • git diff --check

Non-goals

  • No public API redesign.
  • No new X.509 fixture profile or claim.
  • No baseline reset.
  • No TLS/mTLS behavior expansion.

What this enables next

  • Restores the no-panic Stage A.5 posture after the X.509 SRP refactor, so the adoption-confidence lane can close with clean policy evidence instead of a known new-debt exception.

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented May 16, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 15 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f07f129b-3c08-4e2e-a228-79c0c085f812

📥 Commits

Reviewing files that changed from the base of the PR and between c183a5c and 1605909.

📒 Files selected for processing (4)
  • crates/uselesskey-x509/src/cert.rs
  • crates/uselesskey-x509/src/cert/material.rs
  • crates/uselesskey-x509/src/cert/params.rs
  • policy/no-panic-baseline.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch policy/no-panic-baseline-x509-refactor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EffortlessSteven EffortlessSteven merged commit 3796b00 into main May 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant