Skip to content

test(jwk): cover builder and negative fixture branches#714

Merged
EffortlessSteven merged 1 commit into
mainfrom
test/jwk-extra-coverage
May 16, 2026
Merged

test(jwk): cover builder and negative fixture branches#714
EffortlessSteven merged 1 commit into
mainfrom
test/jwk-extra-coverage

Conversation

@EffortlessSteven

@EffortlessSteven EffortlessSteven commented May 16, 2026

Copy link
Copy Markdown
Member

Summary

Files added/changed

  • crates/uselesskey-jwk/tests/jwk_extra_coverage.rs: added focused branch and fixture-confidence tests
  • crates/uselesskey-jwk/Cargo.toml: adds uselesskey-test-support as a dev-dependency
  • Cargo.lock: records the dev-dependency edge

Validation

  • cargo test -p uselesskey-jwk --test jwk_extra_coverage --all-features
  • cargo test -p uselesskey-jwk --all-features
  • cargo clippy -p uselesskey-jwk --tests --all-features -- -D warnings
  • cargo xtask fmt
  • cargo +nightly xtask pr-lite
  • cargo xtask check-no-panic-family: no new JWK debt remains; still fails on three pre-existing X.509 sites already present on main
  • cargo xtask pr: passed through package tests, clippy, feature matrix, BDD, and package checks; failed only at local Windows fuzz execution with STATUS_DLL_NOT_FOUND
  • cargo xtask doctor: confirms clang_rt.asan_dynamic-x86_64.dll is not on PATH
  • git diff --check

Non-goals

  • no JWK API behavior changes
  • no public claim changes
  • no generated fixture or badge changes
  • no broad no-panic baseline cleanup

What this enables next

@claude @EffortlessSteven
test(jwk): cover Jwks::to_value, builder default, negative variant ma…
63738d9 
…trix

Adds direct unit tests for:

- `Jwks::to_value()` (was only exercised via `Display`).
- `JwksBuilder::default()` equivalence to `new()` and `KidSorted::new`/
  `default` empty-state invariants, plus stability of 10 equal-kid pushes.
- `PublicJwk::negative_value` / `PrivateJwk::negative_value` across every
  concrete enum arm (RSA / EC / OKP / Oct) × every `NegativeJwk` variant.
  This nails the `WrongKty` else-branch for non-RSA inputs (OKP, Oct, EC)
  and the per-shape field-lookup order for `MalformedField` and
  `MismatchedParameters`.
- `NegativeJwks::DuplicateKey` on a populated set — the existing tests
  only covered the empty-set scanner-safe fallback.
@gemini-code-assist

gemini-code-assist Bot commented May 16, 2026

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented May 16, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented May 16, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 58 minutes and 37 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bfb1645d-7bbb-4f65-8ae3-663d09b831d3

📥 Commits

Reviewing files that changed from the base of the PR and between d2447f8 and 63738d9.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • crates/uselesskey-jwk/Cargo.toml
  • crates/uselesskey-jwk/tests/jwk_extra_coverage.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/jwk-extra-coverage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EffortlessSteven EffortlessSteven merged commit 9e8f12c into main May 16, 2026
6 checks passed
@EffortlessSteven EffortlessSteven mentioned this pull request May 16, 2026
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EffortlessSteven @claude