xtask: add generated badge endpoints#605
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9db1e0be0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fn ripr_plus_badge() -> Result<ShieldsEndpointBadge> { | ||
| let ripr_bin = env::var("RIPR_BIN").unwrap_or_else(|_| "ripr".to_string()); | ||
| let output = Command::new(&ripr_bin) | ||
| .args(["check", "--root", ".", "--format", "repo-badge-plus-shields"]) |
There was a problem hiding this comment.
Resolve badge generation from the workspace root
When cargo xtask badges is invoked from a workspace subdirectory such as xtask/, this --root . points ripr at only that subdirectory, and the surrounding badge reads/writes also use subdirectory-relative badges/ and target/xtask/badges. In that context the command can report success while creating xtask/badges/* and leaving the public repo-root /badges endpoints stale; root the command and badge paths via workspace_root_path() instead.
Useful? React with 👍 / 👎.
Summary
Validation
Notes