Skip to content

refactor(token): fold token shards into owner crate#483

Merged
EffortlessSteven merged 2 commits into
mainfrom
codex/token-demicrocrate-fold
May 8, 2026
Merged

refactor(token): fold token shards into owner crate#483
EffortlessSteven merged 2 commits into
mainfrom
codex/token-demicrocrate-fold

Conversation

@EffortlessSteven

@EffortlessSteven EffortlessSteven commented May 8, 2026

Copy link
Copy Markdown
Member

Summary

  • Move TokenSpec, base62 helpers, token-shape generation, and NegativeToken under uselesskey-token::srp::* while preserving the supported uselesskey-token root exports.
  • Convert uselesskey-token-spec, uselesskey-core-base62, uselesskey-core-token-shape, and uselesskey-core-token into published-internal compatibility shims.
  • Update publish/mutant ordering, PR impact planning, public-surface docs, support metadata, changelog, and the token-only facade test gate.
  • Add mutation-proof tests for the moved base62 acceptance boundary and JWT negative-shape helpers after hosted xtask pr exposed missed mutants.

Validation

  • cargo test -p uselesskey-token --all-features
  • cargo test -p uselesskey-token-spec -p uselesskey-core-base62 -p uselesskey-core-token-shape -p uselesskey-core-token
  • cargo test -p uselesskey --features token
  • cargo test -p uselesskey-cli --all-features
  • cargo test -p uselesskey-bdd-steps --no-default-features --features uk-core-token-shape
  • cargo check --manifest-path fuzz/Cargo.toml --bins (passed; unrelated fuzz lockfile blake3/cpufeatures churn was not kept in this PR)
  • cargo xtask examples-smoke
  • cargo xtask docs-sync --check
  • cargo xtask public-surface
  • cargo xtask no-blob
  • cargo xtask publish-preflight --allow-dirty
  • cargo xtask lint-fix --check
  • cargo test -p xtask
  • cargo mutants --all-features --manifest-path crates/uselesskey-token/Cargo.toml
  • git diff --check

Review Notes

  • A review agent found no blocking issues. It flagged hidden srp paths being presented as user-facing canonical imports; the shim README and support-matrix wording now points users to supported crate paths while leaving SRP modules as the internal ownership target.
  • First hosted CI run failed only in mutation testing for moved token helper surfaces; the second commit adds focused coverage and the targeted local mutation lane is clean.

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented May 8, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 45 minutes and 20 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: cc2285c7-1ab6-46eb-aecf-b36a71a5890e

📥 Commits

Reviewing files that changed from the base of the PR and between 6ac5030 and 22a3e3d.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (28)
  • CHANGELOG.md
  • crates/uselesskey-core-base62/Cargo.toml
  • crates/uselesskey-core-base62/README.md
  • crates/uselesskey-core-base62/src/lib.rs
  • crates/uselesskey-core-token-shape/Cargo.toml
  • crates/uselesskey-core-token-shape/README.md
  • crates/uselesskey-core-token-shape/src/lib.rs
  • crates/uselesskey-core-token/Cargo.toml
  • crates/uselesskey-core-token/README.md
  • crates/uselesskey-core-token/src/lib.rs
  • crates/uselesskey-token-spec/Cargo.toml
  • crates/uselesskey-token-spec/README.md
  • crates/uselesskey-token-spec/src/lib.rs
  • crates/uselesskey-token/Cargo.toml
  • crates/uselesskey-token/README.md
  • crates/uselesskey-token/src/lib.rs
  • crates/uselesskey-token/src/srp/base62.rs
  • crates/uselesskey-token/src/srp/mod.rs
  • crates/uselesskey-token/src/srp/shape.rs
  • crates/uselesskey-token/src/srp/spec.rs
  • crates/uselesskey-token/src/token.rs
  • crates/uselesskey/tests/cache_perf_tests.rs
  • docs/architecture/public-surface.md
  • docs/explanation/architecture.md
  • docs/metadata/workspace-docs.json
  • docs/reference/support-matrix.md
  • xtask/src/main.rs
  • xtask/src/plan.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/token-demicrocrate-fold

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EffortlessSteven EffortlessSteven merged commit 414db92 into main May 8, 2026
6 checks passed
@EffortlessSteven EffortlessSteven deleted the codex/token-demicrocrate-fold branch May 8, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant