Skip to content

fix: preserve X.509 chain determinism after #279#315

Merged
EffortlessSteven merged 2 commits into
mainfrom
fix/x509-post-279
Mar 27, 2026
Merged

fix: preserve X.509 chain determinism after #279#315
EffortlessSteven merged 2 commits into
mainfrom
fix/x509-post-279

Conversation

@EffortlessSteven

@EffortlessSteven EffortlessSteven commented Mar 27, 2026

Copy link
Copy Markdown
Member

Summary

  • preserve pre-fixture: add x.509 trust/time/path negatives #279 ChainSpec stable bytes for default and DaysAgo-only shapes so unchanged chain fixtures keep their existing deterministic certificate outputs
  • keep the richer v3 encoding for DaysFromNow and intermediate CA/key-usage overrides
  • add a chain-level serial regression test that catches the next_serial_number &= -> |= mutant in crates/uselesskey-x509/src/chain.rs

Validation

  • cargo test -p uselesskey-core-x509-spec
  • cargo test -p uselesskey-x509 --test x509_unit
  • cargo test -p uselesskey-x509 --test x509_comprehensive
  • cargo test -p uselesskey-integration-tests --features determinism-regression --test determinism_regression x509_chain_fingerprints_snapshot -- --exact
  • cargo mutants --all-features --manifest-path crates/uselesskey-x509/Cargo.toml --re "crates/uselesskey-x509/src/chain.rs:759:14: replace &= with \|= in next_serial_number" -j 1
  • cargo xtask gate --check

@gemini-code-assist

gemini-code-assist Bot commented Mar 27, 2026

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Mar 27, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 14 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 6 minutes and 14 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ceda8867-192f-411e-b1b5-8c49e2e4fb68

📥 Commits

Reviewing files that changed from the base of the PR and between 42fcc4d and 7397a28.

⛔ Files ignored due to path filters (3)
  • crates/uselesskey-core-x509-spec/tests/snapshots/snapshots_x509_spec__chain_spec_custom.snap is excluded by !**/*.snap
  • crates/uselesskey-core-x509-spec/tests/snapshots/snapshots_x509_spec__chain_spec_default.snap is excluded by !**/*.snap
  • crates/uselesskey-core-x509-spec/tests/snapshots/snapshots_x509_spec__chain_spec_stable_bytes.snap is excluded by !**/*.snap
📒 Files selected for processing (7)
  • crates/uselesskey-core-x509-spec/src/chain_spec.rs
  • crates/uselesskey-core-x509-spec/tests/comprehensive.rs
  • crates/uselesskey-core-x509-spec/tests/mutant_killers.rs
  • crates/uselesskey-core-x509-spec/tests/spec_edge_cases.rs
  • crates/uselesskey-core-x509-spec/tests/spec_integration_tests.rs
  • crates/uselesskey-x509/tests/x509_comprehensive.rs
  • crates/uselesskey-x509/tests/x509_unit.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/x509-post-279

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EffortlessSteven EffortlessSteven merged commit 7397a28 into main Mar 27, 2026
3 checks passed
@EffortlessSteven EffortlessSteven deleted the fix/x509-post-279 branch April 3, 2026 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EffortlessSteven