release: prepare v0.5.0 cleanup artifacts#302
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request finalizes the release artifacts and documentation for version 0.5.0, reflecting the successful completion of the "adapter wave." It updates the project's roadmap and changelog to accurately represent the newly shipped features and infrastructure improvements, ensuring all release-related documentation is current and consistent. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request finalizes the v0.5.0 release, updating the CHANGELOG.md with new features such as the uselesskey-jose-openid and uselesskey-pgp-native adapter crates, and marking corresponding roadmap items as complete in the documentation. The review identifies a critical issue where the CHANGELOG.md claims updates to files (like README.md and Cargo.tomls) that are not included in the PR, and stresses the importance of updating all version references from 0.4.1 to 0.5.0 across the repository for release consistency. Additionally, it suggests improving the roadmap-followups documentation by replacing generic "Adapter A" and "Adapter B" placeholders with the actual names of the newly implemented adapters for better clarity.
| - Moved README, adapter matrix, and workspace documentation to the cleaner | ||
| adapter-wave wording and boundary-focused guidance. |
There was a problem hiding this comment.
This changelog entry states that README.md, the adapter matrix, and workspace documentation were updated. However, README.md and other files with version numbers (like docs/metadata/workspace-docs.json and various Cargo.toml files) are not part of this pull request's changes. For a v0.5.0 release, it's crucial to update all version references from 0.4.1 to 0.5.0 in these files to avoid user confusion. Please ensure all relevant files are updated and included in this PR.
| - [x] Adapter A | ||
| - [x] Adapter B |
There was a problem hiding this comment.
For better clarity and historical reference, it would be beneficial to replace the generic placeholders 'Adapter A' and 'Adapter B' with the actual names of the adapters that were implemented, which appear to be uselesskey-jose-openid and uselesskey-pgp-native based on the changelog.
| - [x] Adapter A | |
| - [x] Adapter B | |
| - [x] `uselesskey-jose-openid` adapter | |
| - [x] `uselesskey-pgp-native` adapter |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b694dc4e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [0.5.0] - 2026-03-25 |
There was a problem hiding this comment.
Update changelog links for the new 0.5.0 section
Adding ## [0.5.0] here without updating the link definitions at the bottom of CHANGELOG.md leaves the new version reference undefined and keeps [Unreleased] pointing to v0.4.1...HEAD, which makes release navigation inconsistent (the unreleased compare range now includes already-released 0.5.0 changes). Please add a [0.5.0] compare link and advance [Unreleased] to v0.5.0...HEAD.
Useful? React with 👍 / 👎.
Closes #278.\n\nAdds release-prep artifacts after adapter wave:\n\n- Marks v0.5.0 follow-up execution items complete in roadmap docs\n- Moves adapter-wave completion into shipped roadmap history\n- Adds