Skip to content

fix: PGP snapshot platform variance + increase PR CI timeout#218

Merged
EffortlessSteven merged 2 commits into
mainfrom
fix/pgp-snapshot-platform
Mar 5, 2026
Merged

fix: PGP snapshot platform variance + increase PR CI timeout#218
EffortlessSteven merged 2 commits into
mainfrom
fix/pgp-snapshot-platform

Conversation

@EffortlessSteven

@EffortlessSteven EffortlessSteven commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What changed

  1. Redacted platform-dependent \private_binary_len\ and \public_binary_len\ in the RSA-3072 PGP snapshot test
  2. Increased PR CI job timeout from 30 to 45 minutes

Why

Snapshot fix

RSA-3072 PGP key binary encoding produces slightly different lengths across platforms:

  • Windows: 1881 / 910
  • Linux (CI): 1880 / 909

The 1-byte difference is due to MPI leading-zero byte encoding in PGP binary format.

Timeout fix

With 36 merged PRs adding significant test coverage:

  • Tool installation: ~5 min (typos-cli, cargo-deny compilation)
  • \cargo xtask pr: ~25-30 min
  • Total: ~30-35 min, exceeding the old 30 min timeout

What I ran locally

  • \cargo test -p uselesskey-pgp --test snapshots_pgp\ — all 8 tests pass
  • \cargo xtask gate --check\ — 4/4 passed
  • Pre-push hook passed

CI jobs relied on as truth

  • Main CI run 22728494345 (PGP snapshot failure)
  • PR CI run 22729721883 (30 min timeout)
  • This PR's CI (pending — new run with 45 min timeout)

Determinism impact: None

No-blob impact: None

Debug leakage risk: None

Docs touched: None

Recommended disposition: MERGE

@EffortlessSteven
fix: redact platform-dependent RSA-3072 PGP binary lengths in snapshot
805525b 
RSA-3072 PGP key binary encoding produces slightly different lengths on
different platforms (1881/910 on Windows vs 1880/909 on Linux) due to
MPI leading-zero byte encoding differences. Redact these values in the
snapshot to make the test cross-platform stable.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Mar 5, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist

gemini-code-assist Bot commented Mar 5, 2026

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Walkthrough

A test snapshot update marks RSA-3072 key metadata binary length values as platform-dependent in the snapshot file. The change documents that RSA MPI leading-zero encoding causes small platform variation in binary sizes during snapshot testing.

Changes

Cohort / File(s) Summary
Test Snapshot Update
crates/uselesskey-pgp/tests/snapshots_pgp.rs		 Updated snapshot expectations for RSA-3072 key metadata by marking .private_binary_len and .public_binary_len as platform-dependent due to MPI encoding variation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through platform sand,
Where bytes dance different, hand in hand,
We mark them "[PLATFORM_DEPENDENT]" true,
So snapshots pass on every view! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check ✅ Passed The title covers the primary change (PGP snapshot platform variance) and an important secondary change (PR CI timeout increase), making it specific and informative about the changeset.
Description check ✅ Passed The description is clearly related to the changeset, providing detailed context for both changes: snapshot fixes with platform-specific binary length differences and CI timeout adjustments with reasoning.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/pgp-snapshot-platform

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EffortlessSteven
fix(ci): increase PR job timeout from 30 to 45 minutes
619862d 
With 36 merged PRs adding significant test coverage, tool installation
takes ~5 min and xtask pr takes ~25-30 min. The 30 min timeout is no
longer sufficient.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@EffortlessSteven EffortlessSteven changed the title fix: redact platform-dependent PGP RSA-3072 binary lengths in snapshot fix: PGP snapshot platform variance + increase PR CI timeout Mar 5, 2026
@EffortlessSteven EffortlessSteven merged commit 38d1f33 into main Mar 5, 2026
4 checks passed
@EffortlessSteven EffortlessSteven deleted the fix/pgp-snapshot-platform branch March 5, 2026 19:12
@coderabbitai coderabbitai Bot mentioned this pull request Mar 14, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@EffortlessSteven