fix(engine/parallel): restore imports after PR #64 absorption drift#71
Conversation
Post-rebase of PR #64 on top of main's policy absorption and registry split, the engine::parallel submodule needed API updates that were not included in the merged PR: - shipper_policy -> crate::runtime::policy (policy was absorbed in main) - shipper_registry::RegistryClient -> HttpRegistryClient alias (the parallel path operates on base-URL, not Registry struct; the full Registry-aware client is named RegistryClient and takes a different constructor after the registry lib split) Fixes compilation of shipper crate on main after PR #64 merge.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 47 minutes and 17 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
PR #64 merged with stale imports that assumed the pre-absorption
shipper_policycrate and the pre-splitshipper_registry::RegistryClientAPI. After merge,cargo check -p shipperon main fails withE0433(unresolvedshipper_policy) andE0599(missingbase_url/fetch_sparse_index_file).Two drift corrections:
engine/parallel/policy.rs:shipper_policy::*->crate::runtime::policy::*(policy was absorbed in main before PR decrating: absorb shipper-engine-parallel into shipper::engine::parallel #64's branch).engine/parallel/{mod,publish,readiness,tests}.rs:shipper_registry::RegistryClient->shipper_registry::HttpRegistryClient as RegistryClient. The parallel engine operates on a bare base-URL and callsbase_url()/fetch_sparse_index_file(), which now live onHttpRegistryClient. The full Registry-aware client inshipper_registry::RegistryClienttakes aRegistrystruct and returnsResult<Self>, which is not what this call path needs.Test plan
cargo check --workspacecleancargo test -p shipper --lib engine::parallel— 65 tests pass