decrating: consolidated CI + docs stale-reference cleanup#62
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 11 minutes and 9 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sweep-cleanup of CI workflows, templates, and docs for references to microcrates and micro-* feature flags that have been deleted or are queued for deletion via absorption PRs #52 #54 #55 #56 #57 #58. Changes: - .github/workflows/ci.yml - removed deleted features (micro-lock, micro-plan, micro-policy, micro-process, micro-store) from BDD matrix - .github/workflows/mutation.yml - removed shipper-plan, shipper-policy, shipper-levels from the mutation-testing target list - .github/workflows/release.yml - added note that publish order is finalized in Phase 8 of the decrating plan - templates/circleci-config.yml - matching feature-matrix cleanup - docs/architecture.md - per-crate absorbed notes in microcrates table plus top-of-section notes on Dependency Graph and Module Responsibilities pointing out those sections reflect pre-decrating state - docs/testing.md - removed deleted crates from example test invocations and the mutation-testing example - RELEASE_CHECKLIST_v0.3.0.md - header note listing absorbed crates and pruned publish steps - RELEASE_NOTES_v0.3.0.md - reworded Modular Architecture bullet to reflect the consolidated public-crate layout References to still-in-flight absorptions (auth, environment, git, storage, engine-parallel, registry, progress) are left alone - they will be cleaned up in their respective absorption PRs. Per docs/decrating-plan.md.
22fcbbd to
30d8cc0
Compare
Scope
Consolidated sweep of CI workflows, templates, and docs for references to microcrates and
micro-*feature flags that are being deleted via decrating absorption PRs #52 #54 #55 #56 #57 #58.Swept (references removed):
shipper-lock(decrating: absorb shipper-lock into shipper::ops::lock #52),shipper-policy(decrating: absorb shipper-policy into shipper::runtime::policy #54),shipper-process(decrating: absorb shipper-process into shipper::ops::process #55)shipper-plan,shipper-levels,shipper-chunking(decrating: absorb shipper-plan + levels + chunking into shipper::plan #56)shipper-store(decrating: absorb shipper-store into shipper::state::store #57),shipper-config-runtime(decrating: absorb shipper-config-runtime into shipper-config::runtime #58)micro-lock,micro-plan,micro-policy,micro-process,micro-storefeature flagsDeliberately left alone (handled by their own absorption PRs):
shipper-auth,shipper-environment,shipper-git(decrating: Phase 1 (hard) — collapse auth dual implementation, preserve shim fallback #51, decrating: Phase 1 (medium batch) — collapse dual implementations for environment/storage/git #53, TBD)shipper-storage(decrating: Phase 1 (medium batch) — collapse dual implementations for environment/storage/git #53, split TBD)shipper-engine-parallel(TBD)shipper-registry(stays public)shipper-progress(TBD)File-by-file summary
.github/workflows/ci.ymlfeature-setmatrix; 14 entries remain.github/workflows/mutation.yml-p shipper-{plan,policy,levels}entries; 5 remain.github/workflows/release.ymltemplates/circleci-config.ymldocs/architecture.mddocs/testing.mdcargo test -p ...list andcargo mutantsexampleRELEASE_CHECKLIST_v0.3.0.mdRELEASE_NOTES_v0.3.0.mdshipper-lockexampleAudit output (zero remaining references to already-absorbed crates outside of documentation markers)
All three remaining hits are comments I added documenting what was removed. Zero functional references remain.
Docs references (
docs/architecture.md,docs/testing.md,RELEASE_*.md) retain crate names in prose or tables, either annotated with Absorbed markers or inside explicit decrating notes. Wholesale rewrites are deferred to the post-Phase-2 doc refresh per the plan.Validation
yaml.safe_load-OKcargo check --workspace- cleancrates/**or anyCargo.tomlfilesNotes / flagged items
.github/workflows/architecture-guard.yml(Phase 0 of decrating) does not yet exist onmain- PR decrating: Phase 0 — plan doc + architecture-guard CI #48 is still open. The "tighten architecture-guard" step in the task brief was skipped; it can be picked up inside PR decrating: Phase 0 — plan doc + architecture-guard CI #48 directly, or in a follow-up once it lands.crates/because their absorption PRs have not merged yet. This PR only touches CI/docs - so once decrating: absorb shipper-lock into shipper::ops::lock #52-decrating: absorb shipper-config-runtime into shipper-config::runtime #58 merge, the workspace will be consistent. If this PR merges first, affected BDD feature-matrix coverage and mutation-testing coverage will be slightly reduced until the absorption PRs land (which is the intent).Test plan
ciworkflow run succeeds on this PR (validates matrix array change)docs/architecture.mdmarkers for accuracyRELEASE_CHECKLIST_v0.3.0.mdpublish order matches current public-crate set