feat(xtask): add advisory doc-contract checker#251
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Droid finished @EffortlessSteven's task —— View job Droid review complete. Validation summary:
No security findings. |
|
|
||
| if let Some(expected_id) = expected_id(document) | ||
| && title_id(title) != Some(expected_id.as_str()) | ||
| { |
There was a problem hiding this comment.
[P1] Missing argument in format string causes runtime panic
The error message in the id_mismatch finding uses a format string with two placeholders ({expected_id} and {}) but only provides one positional argument. When title is None, the second placeholder receives no value, triggering a panic at runtime. This code path is reachable whenever a document's filename ID does not match its title — a common case during document authoring.
| if let Some(expected_id) = expected_id(document) | |
| && title_id(title) != Some(expected_id.as_str()) | |
| { | |
| message: format!( | |
| "filename ID `{}` does not match title `{}`", | |
| expected_id, | |
| title.unwrap_or("<missing title>") | |
| ), |
Summary
Validation